Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory Setup fields for Intrastat #27919

Closed
wants to merge 13 commits into from

Conversation

AnnaMalekITIntegro
Copy link

@AnnaMalekITIntegro AnnaMalekITIntegro commented Jan 10, 2025

Summary

This PR contains new setup for mandatory fields used in Intrastat.
Setup fields are added to Intrastat Report Setup and are used in Sales, Purchase and Transfer documents, before posting.

3 additional fields described in the Idea have not been added, because without changing how Intrastat works and from this data are gained this setup won't work correctly.

Work Item(s) #27681

Fixes #27681

Fixes AB#332149

@AnnaMalekITIntegro AnnaMalekITIntegro requested a review from a team as a code owner January 10, 2025 12:04
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Jan 10, 2025
@AnnaMalekITIntegro
Copy link
Author

@AnnaMalekITIntegro please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="IT.integro sp. z o.o."

@JesperSchulz JesperSchulz added SCM GitHub request for SCM area Needs community review/approval PRs needs atleast 2 reviewers from the community to approve. labels Jan 13, 2025
@JesperSchulz
Copy link
Contributor

Hi @AnnaMalekITIntegro,

I'd love to get these changes in in time for 2025 wave 1, but I would need some tests in order to process this PR. Do you happen to have some tests you can add, which verify that your changes work as intended?

@AnnaMalekITIntegro
Copy link
Author

Hi @AnnaMalekITIntegro,

I'd love to get these changes in in time for 2025 wave 1, but I would need some tests in order to process this PR. Do you happen to have some tests you can add, which verify that your changes work as intended?

Hi,
I'll add tests to the end of this week.

@AnnaMalekITIntegro
Copy link
Author

Hi @JesperSchulz
Please let me know if this is enough :)

@JesperSchulz JesperSchulz added processing-PR The PR is currently being reviewed and removed Needs community review/approval PRs needs atleast 2 reviewers from the community to approve. labels Jan 30, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jan 30, 2025

Alright! Let's do this one! Only challenge: as we already have that feature in CZ, we need to delocalize, which will take some more time than usual. But we'll get there!

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Feb 11, 2025

@AnnaMalekITIntegro, @VolodySyn has merged your idea with the code we had in CZ version to make de-localization easier. You will find that the code is slightly different from what you suggested, but it should fully support the scenario you were looking for!

I will merge this code (if it compiles) and then we'll update it once the internal PR has been processed. The feature is set to release with 26.0 in April!

@AnnaMalekITIntegro
Copy link
Author

@JesperSchulz please let me know if I should do anything in this PR. :)

@JesperSchulz
Copy link
Contributor

@JesperSchulz please let me know if I should do anything in this PR. :)

There is no action on you. The feature has been added. I will close this PR, as your requested changes should have been addressed 😊

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed SCM GitHub request for SCM area ships-in-future-update Fix ships in a future update
Projects
None yet
3 participants